Remove Env::default #1837
Merged
Remove Env::default #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes this sounds good. Give me a few days to get back into this. |
pleshevskiy
reviewed
Jul 2, 2021
druid/src/theme.rs
Outdated
| @@ -186,5 +186,5 @@ pub(crate) fn add_to_env(env: Env) -> Env { | |||
|
|
|||
| #[deprecated(since = "0.7.0", note = "use Env::default() instead")] | |||
There was a problem hiding this comment.
I think we should also change the note to following
#[deprecated(since = "0.7.0", note = "use Env::with_default_i10n() instead")]or Env::empty(). You know best :)
There was a problem hiding this comment.
Can we just remove this? I don't think this is a popular function 🤔
There was a problem hiding this comment.
agree, there's no good way to use this right now.
PoignardAzur
approved these changes
Aug 4, 2021
This was a bit of a footgun; it would always configure localization resources, which doesn't make sense if we want to use an `Env` as just a bag of key/values in some contexts. Specifically, we may want to do this for #1658. The fix is a two-parter: - the `LocalizationManager` owned by the env is now optional, although it is expected to exist for the root env. The framework makes sure this is the case. - There is a new `Env::empty` method that creates a new empty environment, with no localization resources. This is suitable for the 'specifying overrides' case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit of a footgun; it would always configure localization
resources, which doesn't make sense if we want to use an
Envas just abag of key/values in some contexts.
Specifically, we may want to do this for #1658.
The fix is a two-parter:
LocalizationManagerowned by the env is now optional, althoughit is expected to exist for the root env. The framework makes sure this
is the case.
Env::emptymethod that creates a new emptyenvironment, with no localization resources. This is suitable for the
'specifying overrides' case.
@arthmis if you're still interested in finishing up #1658, then I would merge this as is, but if that is in doubt I would probably remove the
empty()method since it isn't really useful anywhere else I can think of?