Fix word selection logic #1665
Merged
Fix word selection logic #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
force-pushed
the
better-word-select
branch
from
076bb04 to
5b2d893
Compare
This is particularly relevant for when the user double-clicks a word. Previously if the click fell on a word boundary we would not recognize that; now if the click falls on a word boundary we will treat that as the start of the new selection range. In addition, word select now selects *anything* between two word boundaries; we do not care if it is actually a word. As an example: if the user double clicks in whitespcae, we will select any contiguous whitespace. progress on #1652
cmyr
force-pushed
the
better-word-select
branch
from
5b2d893 to
42672bc
Compare
|
I'm going to merge this because I have another patch that will heavily conflict. If there are any problems in the logic here I'm sure we'll hear about them. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly relevant for when the user double-clicks a word.
Previously if the click fell on a word boundary we would not
recognize that; now if the click falls on a word boundary we will
treat that as the start of the new selection range.
In addition, word select now selects anything between two word
boundaries; we do not care if it is actually a word. As an example:
if the user double clicks in whitespcae, we will select any
contiguous whitespace.
progress on #1652
This will conflict with #1653, so I should maybe start merging some of these.