Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Link type #1656

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Export Link type #1656

merged 1 commit into from
Mar 17, 2021

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Mar 17, 2021

This type is part of public API and is linked in some doc comments
so it makes sense that the type be accessible.

@cmyr
Export Link type
0c2d6a6 
This type is part of public API and is linked in some doc comments
so it makes sense that the type be accessible.
maan2003
maan2003 approved these changes Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@maan2003 maan2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I totally forgot about this. I thought module attribute was public

@cmyr
Copy link
Member Author

cmyr commented Mar 17, 2021

so did I, I just noticed I was getting a warning when testing the docs. 🤷

@cmyr cmyr merged commit 3e763f4 into master Mar 17, 2021
@cmyr cmyr deleted the docs-fixup branch March 17, 2021 17:58
@cmyr
Copy link
Member Author

cmyr commented Mar 17, 2021

note to self: we should have --document-private-items set in the docs step of CI, that would have caught this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maan2003 maan2003 maan2003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmyr @maan2003