Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple markdown editor example #1513

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Add simple markdown editor example #1513

merged 1 commit into from
Jan 7, 2021

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Jan 7, 2021

In the process of writing up a small 0.7.0 release post I noticed we didn't really have any example code that demonstrates rich text stuff at all. This adds a simple markdown editor demo that I had sitting around.

@rjwittams rjwittams merged commit 5f3d9db into master Jan 7, 2021
@alerque
Copy link

alerque commented Jan 7, 2021

I understand the utility in having a rich text example here, but I do get a bit squeamish at the prospect of including a Markdown parser in the bargain. Markdown parsing is one of those things that seems simple at first blush and the ecosystem is cluttered with things that sort of work until they fall on their face. Kind of like Adobe and others insisting on writing their own shapers or people blindly assuming BiDi is easy. Not saying this can't go it, but maybe a comment highlighting the POC nature to be used for the display code not as a starting point for any real Rust based Markdown parsing would be in order.

@rjwittams
Copy link
Collaborator

Do you mean the dev dependency on pulldown-cmark? Or something else

@cmyr cmyr deleted the markdown-preview branch January 7, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants