Expose word wrap in TextLayout and Label #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
force-pushed
the
text-layout-width
branch
from
d598323 to
a3d1b41
Compare
|
This looks really good! (Looking at the pics not code! ) |
cmyr
force-pushed
the
text-layout-width
branch
from
a3d1b41 to
ca40deb
Compare
cmyr
force-pushed
the
text-layout-width
branch
from
ca40deb to
832b17e
Compare
raphlinus
reviewed
Sep 9, 2020
|
This should get a changlog entry. |
|
I'm going to rework this to have a different API. |
cmyr
force-pushed
the
text-layout-width
branch
3 times, most recently
from
9a3a716 to
ce1cbd8
Compare
|
Okay, I've reworked this significantly so that instead of exposing an explicit wrap-width in label, we expose a |
|
That looks glorious |
cmyr
added
S-needs-review
raphlinus
approved these changes
Sep 11, 2020
With this patch, the TextLayout object can now be given a width for wrapping words. This is exposed in the Label via a new LineBreaking enum, with three options. With LineBreaking::WordWrap, the TextLayout's wrap-width is set to the maximum width of the label's BoxConstraints, and lines are broken appropriately. The other two options (LineBreaking::Overflow and LineBreaking::Clip) both disable line-breaking; in the former case if text exceeds the width of the label it is painted outside of the label's bounds, and in the latter case the text is clipped to the bounds of the label. It would be nice if, in the clipping case, we could use a gradient mask or something to fade the edges of the clipped text, but I don't believe this is currently possible in piet. A simple alternative of drawing a gradient from (transparent -> label background color) doesn't work, because label's do not have an explicit background color, which I think is also correct. progress on #1192
cmyr
force-pushed
the
text-layout-width
branch
from
ce1cbd8 to
7261854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, the TextLayout object can now be given a width
for wrapping words. This is exposed in the Label via a new
LineBreaking enum, with three options. With LineBreaking::WordWrap,
the TextLayout's wrap-width is set to the maximum width of the label's
BoxConstraints, and lines are broken appropriately. The other two
options (LineBreaking::Overflow and LineBreaking::Clip) both disable
line-breaking; in the former case if text exceeds the width of
the label it is painted outside of the label's bounds, and in the
latter case the text is clipped to the bounds of the label.
It would be nice if, in the clipping case, we could use a gradient
mask or something to fade the edges of the clipped text, but I don't
believe this is currently possible in piet. A simple alternative
of drawing a gradient from (transparent -> label background color)
doesn't work, because label's do not have an explicit background color,
which I think is also correct.
progress on #1192
