[DRAFT] add REPO_SYNC to disable repo sync

[hellodword]

related pr #160 but less changes

[bananer]

Documenting that option in the readme would be good.

Some local changes will still be lost, this might also be relevant for the documentation. See

docker-lineage-cicd/src/build.sh

Lines 159 to 168 in 5c35c2e

	# Remove previous changes of vendor/cm, vendor/lineage and frameworks/base (if they exist)
	# TODO: maybe reset everything using https://source.android.com/setup/develop/repo#forall
	for path in "vendor/cm" "vendor/lineage" "frameworks/base" "packages/apps/PermissionController" "packages/modules/Permission"; do
	if [ -d "$path" ]; then
	cd "$path"
	git reset -q --hard
	git clean -q -fd
	cd "$SRC_DIR/$branch_dir"
	fi
	done

[bananer]

This seems unrelated

[hellodword]

This seems unrelated

I'm sorry, removed.

Some local changes will still be lost

Yes, but changes will be applied again, for example:

docker-lineage-cicd/src/build.sh

Lines 198 to 200 in 5c35c2e

	# Set up our overlay
	mkdir -p "vendor/$vendor/overlay/microg/"
	sed -i "1s;^;PRODUCT_PACKAGE_OVERLAYS := vendor/$vendor/overlay/microg\n;" "vendor/$vendor/config/common.mk"

It will be:

PRODUCT_PACKAGE_OVERLAYS := vendor/$vendor/overlay/microg
PRODUCT_PACKAGE_OVERLAYS := vendor/$vendor/overlay/microg
PRODUCT_PACKAGE_OVERLAYS := vendor/$vendor/overlay/microg
...

And I think this will be confused with the name REPO_SYNC, maybe we need another setting name? Any idea?

[petefoth]

I think it would be clearer if we call the flag SKIP-REPO_SYNC, and invert the logic of the code in build.sh (and change the docs to match)

[hellodword]

I think it would be clearer if we call the flag SKIP-REPO_SYNC, and invert the logic of the code in build.sh (and change the docs to match)

That's a better way but will cause much changes in build.sh.

And should we really define the overlay setting and patches applying as parts of REPO SYNC?

Maybe another setting name about read-only is better, which means this will only try to build and never modify any source code you've synced or modified before :)

[petefoth]

Good questions. Too many open questions for this to get merged for Friday's build run. I'll set the PR back to Draft, and we can give it some more tghought in the next couple of weeks

[petefoth]

Assigned back to @hellodword for requested changes

Converted to 'Drafy'

[petefoth]

Too many outstanding issues for this to be merged yet:

1. Documentation
2. Answer to @bananer's review question

[petefoth]

Closing. The requested functionality is implemented in Make the operations performed by the docker image 'switchable' #508 , which was merged to the master branch in #571