topic:mirror-generator-modernize #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import `re` - No bare `except` - Space before colon in lambda Signed-off-by: Han Sol Jin <[email protected]>
Signed-off-by: Han Sol Jin <[email protected]>
|
mmm, should I be signing off the cherry-picked commit too? |
- `filepath` and `filename` are the same thing, just use `filename` - `BASE_PATH` and `FILE_BASE` are the same thing, just use `BASE_PATH` - Account for possibility that `BASE_PATH` may not have a trailing slash Signed-off-by: Han Sol Jin <[email protected]>
Since Oreo, there is no `system/build.prop`, it is packaged into `system.new.dat`. So timestamp generation hasn't worked for years now. The OTA metadata on the other hand stores this timestamp (called `post-timestamp`), so let's parse that instead.
… builds Signed-off-by: Han Sol Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR contains a cherry-pick from #51 (with a commit message overhaul).