Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UpdateLiffView for liff.yml #69

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

odanado
Copy link
Member

@odanado odanado commented Oct 11, 2024

In LiffView, view.url and view.type are required properties. However, in the LIFF app update API, these properties are not mandatory.
ref: https://developers.line.biz/en/reference/liff-server/#update-liff-app

I have defined a new UpdateLiffView to solve this issue.

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024

CLA assistant check
All committers have signed the CLA.

@habara-k habara-k self-assigned this Oct 22, 2024
@habara-k habara-k added the keep Avoid auto close label Oct 22, 2024
@habara-k habara-k self-requested a review October 24, 2024 06:00
@habara-k habara-k removed their assignment Oct 24, 2024
Copy link
Contributor

@habara-k habara-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for always using the line-bot-sdk. We appreciate your contribution.

@habara-k habara-k merged commit 4d9979b into line:main Oct 24, 2024
8 checks passed
@odanado odanado deleted the update-LiffView-of-UpdateLiffAppRequest branch October 24, 2024 07:29
habara-k pushed a commit to line/line-bot-sdk-nodejs that referenced this pull request Oct 24, 2024
The `view.type` and `view.url` in the request body of [PUT
https://api.line.me/liff/v1/apps/{liffId}](https://developers.line.biz/en/reference/liff-server/#update-liff-app)
are not required.
This PR modifies them to be optional.

line/line-openapi#69

Co-authored-by: github-actions <[email protected]>
habara-k pushed a commit to line/line-bot-sdk-java that referenced this pull request Oct 24, 2024
The `view.type` and `view.url` in the request body of [PUT
https://api.line.me/liff/v1/apps/{liffId}](https://developers.line.biz/en/reference/liff-server/#update-liff-app)
are not required.
This PR modifies them to be optional.

line/line-openapi#69

Co-authored-by: github-actions <[email protected]>
habara-k pushed a commit to line/line-bot-sdk-python that referenced this pull request Oct 24, 2024
The `view.type` and `view.url` in the request body of [PUT
https://api.line.me/liff/v1/apps/{liffId}](https://developers.line.biz/en/reference/liff-server/#update-liff-app)
are not required.
This PR modifies them to be optional.

line/line-openapi#69

Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep Avoid auto close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants