ProcessorSubscription refactoring #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawamuray
force-pushed
the
subsc-refactoring
branch
from
9fef5d5 to
9573c31
Compare
ocadaruma
reviewed
Aug 29, 2020
kawamuray
force-pushed
the
subsc-refactoring
branch
from
9573c31 to
9710975
Compare
|
@ocadaruma sorry for orphaning this for a long time. I've revised patch onto latest master and made some improvements. PTAL when you have time. |
ocadaruma
reviewed
Dec 24, 2020
| @Value | ||
| @Accessors(fluent = true) | ||
| static | ||
| class AssignmentConfig { |
There was a problem hiding this comment.
[nits] We don't break line between static class I think
There was a problem hiding this comment.
hm.. how could this happen. will fix, thx.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we talked in #53 ,
ProcessorSubscription's getting bigger and complex by many functions being added to it.I've attempted to refactor it by mainly extracting things into a separate classes.
The work is still in progress and I'm still considering what would be the best design (especially for TaskConsumer).
Please give early feedback if any!
Some notable changes that might impacts decaton's behavior:
OffsetRegressionException+ on-demand repair.contexts.maybeHandlePropertyReload()now happens after updateHighWatermark, pause, resume