Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spring boot 3 on decaton-spring #210

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

koyapei
Copy link
Member

@koyapei koyapei commented Aug 8, 2023

motivation

There has been a change in the auto-configuration file in Spring Boot 3.
https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#auto-configuration-files

In the decaton-spring module, it is necessary to support both boot 2 and boot 3 until migrating to boot 3.

modification

  • In addition to the spring.factories used in boot 2, a new configuration file spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports was added for boot 3 in META-INF.
  • Integration tests have been created to verify that auto-configuration works in both boot 2 and boot 3.
    • If these tests are excessive, I'll remove them.

@kawamuray
Copy link
Contributor

https://spring.io/projects/spring-boot#support

spring boot 2 will soon reach EOL, so it would be okay to just drop spring boot2 support in this PR?

@koyapei
Copy link
Member Author

koyapei commented Aug 8, 2023

spring boot 3 requires Java 17 or higher, so if we discontinue support for spring boot 2, we also need to discontinue support for Java 16 or lower at the same time.
https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#review-system-requirements

Although it is possible to discontinue support for them in decaton-spring, it is not highly desirable as it would compromise consistency of java's version with other modules.

@kawamuray kawamuray added the new feature Add a new feature label Aug 8, 2023
@kawamuray
Copy link
Contributor

I see. Sounds like a good comprise then.

Copy link
Contributor

@kawamuray kawamuray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kawamuray kawamuray merged commit 06bd377 into line:master Aug 8, 2023
@koyapei koyapei deleted the support-boot-3 branch August 8, 2023 09:41
@koyapei
Copy link
Member Author

koyapei commented Aug 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants