Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle RebalanceInProgressException on sync commit fixes #201 #202

Merged
merged 3 commits into from
May 10, 2023
Merged

Handle RebalanceInProgressException on sync commit fixes #201 #202

merged 3 commits into from
May 10, 2023

Conversation

ocadaruma
Copy link
Contributor

  • As described in the issue, RebalanceInProgressException also could be thrown on commitSync, which should not be treated as fatal

@ocadaruma ocadaruma requested a review from kawamuray May 10, 2023 08:26
kawamuray
kawamuray approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@kawamuray kawamuray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix.

@kawamuray kawamuray merged commit 36106b2 into line:master May 10, 2023
@ocadaruma ocadaruma deleted the handle-rebalance-in-progress branch May 10, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kawamuray kawamuray kawamuray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocadaruma @kawamuray