Add retry count metric #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mosmeh
force-pushed
the
retry-count-metric
branch
from
bc8a8ce to
0db74ac
Compare
ajalab
reviewed
Dec 16, 2022
processor/src/main/java/com/linecorp/decaton/processor/metrics/Metrics.java
Outdated
Show resolved
Hide resolved
mosmeh
force-pushed
the
retry-count-metric
branch
from
4e704e7 to
edc1b44
Compare
ocadaruma
reviewed
Dec 16, 2022
.../java/com/linecorp/decaton/processor/runtime/internal/DecatonTaskRetryQueueingProcessor.java
Outdated
Show resolved
Hide resolved
ajalab
approved these changes
Dec 16, 2022
ocadaruma
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In our use cases, we try to detect repeated failures of task processing by logging when tasks are retried.
However, frequent repeated logs tend to be ignored, so we may not notice repeated processing failures for a long time.
Instead, this PR introduces a retry count metric, which can be used for alerting based on thresholds.