Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use centraldogma 0.57 #169

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Use centraldogma 0.57 #169

merged 2 commits into from
Sep 15, 2022

Conversation

mauhiz
Copy link
Contributor

@mauhiz mauhiz commented Sep 8, 2022

Contents

  • Bump dependencies for CD, Jackson, SLF4J, Logback
  • Fix deprecation warnings related to CD (which recently introduced CentralDogmaRepository)

After this PR, decaton will require CD v0.55+ ( https://github.com/line/centraldogma/releases )

@mauhiz mauhiz marked this pull request as ready for review September 8, 2022 09:28
@mauhiz
Copy link
Contributor Author

mauhiz commented Sep 14, 2022

ping maintainers ( @ocadaruma )

ocadaruma
ocadaruma reviewed Sep 15, 2022
View reviewed changes
Copy link
Contributor

@ocadaruma ocadaruma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for delaying the review.

Left nits comment but overall looks good

build.gradle Outdated Show resolved Hide resolved
@ocadaruma ocadaruma merged commit 732f24d into line:master Sep 15, 2022
@mauhiz mauhiz mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocadaruma ocadaruma ocadaruma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauhiz @ocadaruma