Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave completion object in ProcessingContext field to avoid leak #124

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Leave completion object in ProcessingContext field to avoid leak #124

merged 1 commit into from
Sep 14, 2021

Conversation

kawamuray
Copy link
Contributor

No description provided.

@kawamuray kawamuray requested a review from ocadaruma September 13, 2021 08:43
ocadaruma
ocadaruma approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@ocadaruma ocadaruma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fixing.

Roughly checked locally that no completion-leak even we call ctx.deferCompletion() multiple times.

@ocadaruma ocadaruma merged commit 1ca26c9 into master Sep 14, 2021
@ocadaruma
Copy link
Contributor

Let me send follow-up PR to add integration tests about this.

@ocadaruma ocadaruma deleted the dc-fixup branch September 14, 2021 07:27
@ocadaruma ocadaruma added the bugfix Fix a bug label Sep 14, 2021
@ocadaruma ocadaruma mentioned this pull request Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocadaruma ocadaruma ocadaruma approved these changes

Assignees
No one assigned
Labels
bugfix Fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kawamuray @ocadaruma