default linger.ms 0 doesn't make sense typically #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawamuray
suggested changes
Jun 7, 2021
| // production burst when processes start to fail. (e.g. due to downstream service down) | ||
| // Since default producer's linger.ms is 0, this could harm Kafka cluster despite we | ||
| // don't much care about retry task's delivery latency typically. So we set reasonable default here. | ||
| producerConfig.setProperty(ProducerConfig.LINGER_MS_CONFIG, "100"); |
There was a problem hiding this comment.
Can you pull this up to somewhere like https://github.com/line/decaton/blob/master/client/src/main/java/com/linecorp/decaton/client/internal/DecatonTaskProducer.java#L42 for ability to easy spot where such defaults are defined.
There was a problem hiding this comment.
I thought about that, but I think making such high linger as the default is only acceptable for retry producers.
But yeah, defining in-line could make spotting the default difficult.
Let me find better way to define defaults for retry producer.
kawamuray
suggested changes
Jun 7, 2021
| @@ -46,6 +48,17 @@ | |||
| @Setter | |||
| @Accessors(fluent = true) | |||
| public class SubscriptionBuilder { | |||
| private static final Map<String, String> presetProducerConfig; | |||
There was a problem hiding this comment.
preset*Retry*ProducerConfig?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
linger.ms = 0unless we explicitly set, since it's kafka-clients's default.Breaking Change
Producerfor sending retry tasks are now configured withlinger.ms=100by default, so will introduce some latency in production unless the property is overwritten by the user.