Reduce some object allocations that are identified as expensive by allocation profiling #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocadaruma
reviewed
May 12, 2021
| MDC.put(PARTITION_KEY, String.valueOf(request.topicPartition().partition())); | ||
| private final boolean enabled; | ||
|
|
||
| public LoggingContext(boolean enabled, String subscriptionId, TaskRequest request, TaskMetadata metadata) { |
There was a problem hiding this comment.
I think it's better to keep current constructor to avoid unnecessary breaking change since this class is considered as public API.
There was a problem hiding this comment.
Good point. Let me follow that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some code in decaton core causes massive object allocations (in proportional to consumed records) that causes high GC pressure.
The most significant ones are String allocation in
LoggingContext(TaskMetadata.toString()) butTaskRequest#idtoo. (which is used only if trace level logging is enabled)In this PR I saved those expensive object allocations by making it lazy or by adding a new flag to opt-out
LoggingContextwhen its not necessary.decaton.logging.mdc.enabled