Add optimized supplier of current HTTP timestamp #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
force-pushed
the
fast-http-timestamp
branch
from
481b46a to
8a245bd
Compare
trustin
reviewed
Oct 18, 2019
| public Instant get() { | ||
| return Instant.now(); | ||
| public String get() { | ||
| return HttpTimestampSupplier.currentTime(); |
There was a problem hiding this comment.
Perhaps we could remove this class and just use HttpTimestampSupplier::currentTime?
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
============================================
- Coverage 73.61% 73.61% -0.01%
- Complexity 9590 9591 +1
============================================
Files 837 838 +1
Lines 36936 36944 +8
Branches 4553 4554 +1
============================================
+ Hits 27190 27195 +5
- Misses 7420 7426 +6
+ Partials 2326 2323 -3
Continue to review full report at Codecov.
|
trustin
reviewed
Oct 19, 2019
| newHeaders.add(HttpHeaderNames.DATE, | ||
| DateTimeFormatter.RFC_1123_DATE_TIME.format( | ||
| ZonedDateTime.now(ZoneOffset.UTC))); | ||
| newHeaders.add(HttpHeaderNames.DATE, HttpTimestampSupplier.currentTime()); |
There was a problem hiding this comment.
Thank you @anuraaga
This PR gave me a good education 👍
ikhoon
approved these changes
Oct 19, 2019
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
As TechEmpower suggests, this caches HTTP timestamps for any given second. I can wire this into the `Date` header after that's in if this makes sense :) ``` Benchmark Mode Cnt Score Error Units HttpTimestampSupplierBenchmark.cached thrpt 5 37665728.115 ▒ 324874.523 ops/s HttpTimestampSupplierBenchmark.notCached thrpt 5 2099035.297 ▒ 1176888.041 ops/s ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As TechEmpower suggests, this caches HTTP timestamps for any given second. I can wire this into the
Dateheader after that's in if this makes sense :)