Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1645 #2156

Closed
wants to merge 4 commits into from
Closed

Issue1645 #2156

wants to merge 4 commits into from

Conversation

mumgmangmange
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


unknown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@trustin
Copy link
Member

trustin commented Oct 8, 2019

@mumgmangmange Gentle ping.

  • You need to make sure OpenSsl is accessed only when a user starts a server with SSL enabled. Currently, OpenSsl is loaded even if you start a plaintext HTTP server only. We could fix this by making Flags.useOpenSsl() lazy.
  • You need to make sure Epoll is accessed only when the current operating system is Linux. This is simpler than the OpenSsl case. You could just guard the access to Epoll with a simple if statement which checks the current operating system.

@minwoox
Copy link
Contributor

minwoox commented Oct 14, 2019

Let me close this issue because you are working on #2184.

@minwoox minwoox closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants