Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a user choose a path when a Thrift/gRPC service has more than two paths. #2167

Closed
trustin opened this issue Oct 7, 2019 · 1 comment · Fixed by #3024
Closed

Allow a user choose a path when a Thrift/gRPC service has more than two paths. #2167

trustin opened this issue Oct 7, 2019 · 1 comment · Fixed by #3024
Milestone

Comments

@trustin
Copy link
Member

trustin commented Oct 7, 2019

For example, a user can bind the same Thrift service at two different paths with some minor differences (e.g. decorators):

HelloService.AsyncIface hello = ...;
Server server = Server.builder()
                      .service("/a", THttpService.of(hello))
                      .service("/b", THttpService.of(hello).decorate(...))
                      .build();

In that case, currently, in DocService UI, a user cannot choose which path (/a or /b) a request should be sent to. We could show some drop-down list so that a user can choose among the available paths.

/cc @linna-li

trustin pushed a commit that referenced this issue Oct 1, 2020
…ne path (#3024)

This commit makes `DocService` allow users choose a request path when an RPC service has more than one path.

Fixes #2167
@trustin trustin added this to the 1.2.0 milestone Oct 1, 2020
@trustin
Copy link
Member Author

trustin commented Oct 1, 2020

Thanks again @linna-li for reporting this issue and @kojilin for fixing it the right way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant