Add support for using JsBarcode in implementations that don't implement measureText #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdbleek
force-pushed
the
measure-text-fix-pr
branch
from
262fe59 to
6189182
Compare
|
Hi and thanks for the contribution 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use an HTML to PDF converter which returns undefined for ctx.measureText(). In this PR we return 0 instead of crashing the JavaScript code.
I was not able to run
node_modules/gulp/bin/gulp.js lintas it complains about ' Unexpected top-level property "predef".' in .eslintrc.If I need to do something else, please let me know