Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #109

Closed
wants to merge 10 commits into from
Closed

Add files via upload #109

wants to merge 10 commits into from

Conversation

steepestdescent
Copy link
Contributor

@steepestdescent steepestdescent commented Oct 28, 2019

This pull request adds the feature Heartbeat Supervision. $SY , $GY as in
SY heartbeatinterval hearbeatcurrentlimit
If you do not send open_evse a heartbeat more frequently than every (uint16_t)heartbeatinterval seconds then open_evse will reduce system ampacity to (uint8_t)hearbeatcurrentlimit amperes

Testing still in progress.

Plays nice with TEMPERATURE_MONITORING. Compiles OK, but consumes incremental ROM and RAM. Testing still in progress.

Copy link

@MBerka MBerka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, clean code with clear comments. With an update to the PIO configuration (env_default is going away and it needed help recognizing the board file; PR submitted), it builds in PlatformIO.

Styling tweaks for consistency, building with recent PlatformIO
@lincomatic
Copy link
Owner

Thanks for the PR. very nicely commented. i had to manually merge it, because your PR did weird stuff like replace whole files, probably due to the space characters getting replaced. i wish there were a way to get git to ignore those.

sorry again for the big delay

@lincomatic lincomatic closed this Dec 18, 2019
@steepestdescent
Copy link
Contributor Author

steepestdescent commented Dec 18, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants