-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files via upload #109
Add files via upload #109
Conversation
env_default -> default_envs, altered board name Addressed minor PlatformIO compile-time warnings
Changed 4-space tabs to spaces to because of pre-existing 8-space tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, clean code with clear comments. With an update to the PIO configuration (env_default is going away and it needed help recognizing the board file; PR submitted), it builds in PlatformIO.
Styling tweaks for consistency, building with recent PlatformIO
Thanks for the PR. very nicely commented. i had to manually merge it, because your PR did weird stuff like replace whole files, probably due to the space characters getting replaced. i wish there were a way to get git to ignore those. sorry again for the big delay |
Hi Sam,
Kind of you to say!
Warm regards,
Tim
…On Tue, Dec 17, 2019 at 5:08 PM lincomatic ***@***.***> wrote:
Thanks for the PR. very nicely commented. i had to manually merge it,
because your PR did weird stuff like replace whole files, probably due to
the space characters getting replaced. i wish there were a way to get git
to ignore those.
sorry again for the big delay
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#109?email_source=notifications&email_token=AJ5GRVLRMCDQ4I2N67TRPT3QZFSWLA5CNFSM4JFUBG3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHEMLSI#issuecomment-566805961>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ5GRVKJPLPN4BPEEOKXX6DQZFSWLANCNFSM4JFUBG3A>
.
|
This pull request adds the feature Heartbeat Supervision. $SY , $GY as in
SY heartbeatinterval hearbeatcurrentlimit
If you do not send open_evse a heartbeat more frequently than every (uint16_t)heartbeatinterval seconds then open_evse will reduce system ampacity to (uint8_t)hearbeatcurrentlimit amperes
Testing still in progress.
Plays nice with TEMPERATURE_MONITORING. Compiles OK, but consumes incremental ROM and RAM. Testing still in progress.