Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session elapsed time should be consistent with session energy #79

Closed
glynhudson opened this issue Dec 1, 2017 · 3 comments
Closed

Session elapsed time should be consistent with session energy #79

glynhudson opened this issue Dec 1, 2017 · 3 comments

Comments

@glynhudson
Copy link
Contributor

I'm running latest dev version with the update to reset the session energy when the car in un-plugged even in the unit is in 'sleep' state (charging timer active). This is working very well.

However I have noticed another issue: the time elapsed resets each time the evse is paused then resumed. IMO the session timer should be consistent with session energy. I would consider pausing then resuming a charge (without un-plugging the car) the be the same charging session therefore the time elapsed should not reset. See illustration video:

https://youtu.be/R8hdGba5Ygw

@lincomatic
Copy link
Owner

lincomatic commented Dec 4, 2017 via email

@lincomatic
Copy link
Owner

OK, it's fixed. We now reset the session counter only when the EV is reconnected after it's been disconnected, so it's consistent w/ the energy counter

ee0f1b3

Thanks for bringing this to my attention.

@glynhudson
Copy link
Contributor Author

Fantastic, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants