Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1935: Change dragDevices to disable scrolling in a ListView when hovers over the screen #2176

Conversation

nqhhdev
Copy link
Member

@nqhhdev nqhhdev commented Dec 8, 2024

Ticket

Solution

  • dragDevices Configuration:

    • Only include PointerDeviceKind.touch in the dragDevices set.
    • Exclude PointerDeviceKind.mouse and other devices to disable mouse/trackpad scrolling.
  • Use ScrollConfiguration:

    • Wrap the entire app or a specific widget subtree with a ScrollConfiguration to enforce this behavior.

Resolved

  • Web:
1.mov
  • Mobile:
Screen.Recording.2024-12-09.at.11.50.04.mov

Copy link

github-actions bot commented Dec 8, 2024

This PR has been deployed to https://linagora.github.io/twake-on-matrix/2176

@nqhhdev nqhhdev changed the title [TESTING] TW-1935: Change dragDevices to disable scrolling in a ListView when hovers over the screen TW-1935: Change dragDevices to disable scrolling in a ListView when hovers over the screen Dec 9, 2024
Copy link
Contributor

@KhaledNjim KhaledNjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoangdat
Copy link
Member

LGTM

What platform you tested on?

@KhaledNjim
Copy link
Contributor

LGTM

What platform you tested on?

I tested on android and web(chrome)

@hoangdat hoangdat merged commit 4185a21 into main Dec 11, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-1935-remove-the-ability-to-move-through-chat-via-left-mouse-click-and-drag branch December 11, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants