Initial PR for reddit wrapper in ReactJS + Typescript #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for all current and future pages
| ); | ||
| } | ||
| if (media.url.indexOf('youtube') !== -1) { | ||
| console.log('SPLIT', media.url.split('watch?v=')); |
| const extension = media.url.split('.')[media.url.split('.').length - 1]; | ||
| if (media.url.indexOf('gfycat') !== -1) { | ||
| return( | ||
| <iframe src={`https://thumbs.${media.url.split('://')[1]}-mobile.mp4`} |
There was a problem hiding this comment.
<iframe
src ...
scrolling='no'
width='640'
....
</iframe>
| return (<img src={media.url} alt=""/>); | ||
| } | ||
| if (extension === 'gifv') { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
It's nasty. Race condition!
| const Markdown = require('react-remarkable'); | ||
|
|
||
|
|
||
| interface IProps { |
There was a problem hiding this comment.
make proper interfaces, reduce usage of any;
| } | ||
|
|
||
| public componentDidMount() { | ||
| const script = document.createElement('script'); |
There was a problem hiding this comment.
component mound append and on componentWillUnmount should remove that script
src/components/home/layout.tsx
Outdated
| @@ -0,0 +1,62 @@ | |||
| import * as React from 'react'; | |||
src/components/home/welcome.tsx
Outdated
| @@ -0,0 +1,72 @@ | |||
| import * as React from 'react'; | |||
src/components/layout.tsx
Outdated
| @@ -0,0 +1,39 @@ | |||
| import * as React from 'react'; | |||
src/components/navbar/login.tsx
Outdated
|
|
||
| const mapDispatchToProps = {authorization}; | ||
|
|
||
| @(connect(null, mapDispatchToProps) as any) |
src/components/navbar/login.tsx
Outdated
| ...this.state, | ||
| submitted: true, | ||
| }; | ||
| this.setState(newState); |
There was a problem hiding this comment.
could be:
this.setState({
...this.state,
submitted: true,
});
| dispatch?: any; | ||
| isVisible?: boolean; | ||
| quanityOfSavedSubreddits?: number; | ||
| whereYouAre?: string; |
| }; | ||
|
|
||
| public render() { | ||
| const authLink = 'https://www.reddit.com/api/v1/authorize?client_id=YJa94gbugND2ZQ&response_type=code&state=42asdf&redirect_uri=http://localhost:8000/auth&duration=permanent&scope=identity'; |
There was a problem hiding this comment.
Should be moved into config and set as AUTH_LINK const imported from constants.
| <div className="auth-top col-xs-12"> | ||
| <div className="auth-urself"> | ||
| <a href={authLink}> | ||
| Auth yourself with Leddit account! |
src/components/navbar/searching.tsx
Outdated
| public handleChange = (event: any): void => { | ||
| const value = event.target.value; | ||
| this.setState( | ||
| { |
There was a problem hiding this comment.
this.setState({...this.state, input:value});
| } | ||
|
|
||
| interface ISubreddits { | ||
| data: Object; |
| }; | ||
|
|
||
| private openSubredditOnClick = (subreddit: any ) => { | ||
| // return (e: any) => { |
There was a problem hiding this comment.
don't push commented code
| return ( | ||
| <div className="saved-subreddit-menu-item search-panel-results" key={subreddit.id}> | ||
| <Link to={`/${subreddit.display_name_prefixed}/`}> | ||
| {/*<span onClick={this.openSubredditOnClick(subreddit)}>*/} |
src/components/not-found.tsx
Outdated
|
|
||
| const NotFound: StatelessComponent<any> = (): any => { | ||
| return ( | ||
| <div>The page you request is not exist.</div> |
There was a problem hiding this comment.
The page you requested doesn't exist.
|
|
||
| public render() { | ||
| const { thread_replies, original_post } = this.props; | ||
| console.log('REPLIES', thread_replies); |
src/constants.ts
Outdated
| @@ -0,0 +1,8 @@ | |||
| export const TITLES = [ | |||
There was a problem hiding this comment.
or actually have it but remove those constants
| @@ -0,0 +1 @@ | |||
| export const object: any = Object; | |||
There was a problem hiding this comment.
missing new line at the end
src/prepare.ts
Outdated
| const subreddits = require('./reducers/reducer_subreddits_search'); | ||
| const nextReducer = combineReducers({ | ||
| routing: routerReducer, | ||
| titleReducer, |
| @@ -0,0 +1,28 @@ | |||
| /* Import redcers */ | |||
src/reducers/display_subreddit.ts
Outdated
| case FETCH_SUBREDDIT: | ||
| return {...state, threads: []}; | ||
| case FETCH_THREAD: | ||
| return {...state, |
src/reducers/titles.ts
Outdated
| @@ -0,0 +1,25 @@ | |||
| import { GET_NEXT_TITLE, TITLES } from '../constants'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.