Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launchd: fix Label: io.github.lima-vm.socket_vmnet.plist -> io.github.lima-vm.socket_vmnet #12

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

AkihiroSuda
Copy link
Member

The previous label was not consistent with other services.

@AkihiroSuda
Copy link
Member Author

cc @jandubois @abiosoft @medyagh

This is potentially a breaking change.
I should have caught this before releasing v1.0.0 🤦

@AkihiroSuda AkihiroSuda added this to the v1.0.1 (tentative) milestone Nov 22, 2022
….lima-vm.socket_vmnet

The previous label was not consistent with other services.

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda changed the title launchd: fix Label: io.github.lima-vm.socket_vmnet.plist -> io.github.lima-vm.socket_vmnet launchd: fix Label: io.github.lima-vm.socket_vmnet.plist -> io.github.lima-vm.socket_vmnet Nov 22, 2022
The new commands (available since macOS 10.10) show the detailed progress and error.

Signed-off-by: Akihiro Suda <[email protected]>
@abiosoft
Copy link

This should not break anything for Colima, the socket is being managed outside of Lima.

@medyagh
Copy link

medyagh commented Dec 1, 2022

thanks @AkihiroSuda we will look out for possible breaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants