-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The root path on centos has no /usr/local/bin #345
Conversation
Signed-off-by: Anders F Björklund <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -38,5 +38,5 @@ else | |||
# Remove legacy systemd service | |||
rm -f "/home/${LIMA_CIDATA_USER}.linux/.config/systemd/user/lima-guestagent.service" | |||
|
|||
sudo lima-guestagent install-systemd | |||
sudo /usr/local/bin/lima-guestagent install-systemd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rather modify $PATH globally?
containerd installer needs /usr/local/bin too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure why containerd doesn't use /usr, but maybe it is related to not using packages ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason it seems like the CentOS containers have it in the path, but not the CentOS VMs ? Weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually sudo
that is dropping it, if you log in as root then you have the /usr/local
in there as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that was only /usr/local/sbin
- there is still no /usr/local/bin
in the PATH for root. Only /root/bin
.
It seems like the containerd installer wasn't happy with just an absolute path...
|
Signed-off-by: Anders F Björklund <[email protected]>
f56f32e
to
f87b176
Compare
Interestingly, this also means that
|
Is this mergeable or still WIP? |
I believe it is mergeable now if you are happy with the I think |
Works too: [anders@lima-centos anders]$ which lima-guestagent
/usr/local/bin/lima-guestagent
[anders@lima-centos anders]$ sudo --preserve-env=PATH which lima-guestagent
/usr/local/bin/lima-guestagent |
Closes #343