Ignore public keys that are not in ssh format #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
pubkey-format
branch
from
ad11b0e to
94c0a36
Compare
jandubois
added a commit
to lima-vm/alpine-lima
that referenced
this pull request
Sep 8, 2021
lima-vm/lima#219 adds quotes around the keys, which must be stripped before the keys get written to ~/.ssh/authorized_keys. Signed-off-by: Jan Dubois <[email protected]>
It seems that some ~/.ssh/*.pub files are public SSL keys, so add some minimal validation before using them as authorized_keys. Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
pubkey-format
branch
from
94c0a36 to
86ab653
Compare
AkihiroSuda
reviewed
Sep 8, 2021
AkihiroSuda
approved these changes
Sep 8, 2021
|
still getting this issue |
|
@asdfghjkl403622 We would need to see the log files to check this further, but I wonder if this isn't related to your all-numeric username, so maybe test again once #243 has been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some ~/.ssh/*.pub files are public SSL keys, so add some minimal validation before using them as authorized_keys.
Ref #104 (comment)