Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: pkg/sftp v1.13.3 (fix weird ls -l result) #211

Merged
merged 1 commit into from
Sep 6, 2021
Merged

go.mod: pkg/sftp v1.13.3 (fix weird ls -l result) #211

merged 1 commit into from
Sep 6, 2021

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Sep 5, 2021 •
edited
Loading

v1.13.0 had a regression, but fixed in v1.13.3 (pkg/sftp#466)

Fix #206 (weird ls -l result)

@AkihiroSuda AkihiroSuda added this to the v0.6.4 milestone Sep 5, 2021
@AkihiroSuda

This comment has been minimized.

Sign in to view
@AkihiroSuda AkihiroSuda mentioned this pull request Sep 5, 2021
Closed
@AkihiroSuda AkihiroSuda changed the title go.mod: pkg/sftp v1.13.3 go.mod: pkg/sftp v1.13.3 (fix weird ls -l result) Sep 5, 2021
@AkihiroSuda AkihiroSuda mentioned this pull request Sep 6, 2021
Closed
jandubois
jandubois approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File ownership seems correct with this PR. Group ownership is still weird; anything I create inside the VM on the mounted volume has root as the group owner (uid:501, gid:0). Not sure if this matters.

This PR probably needs to be rebased on master to get the CI fix from #212

@jandubois
Copy link
Member

This PR probably needs to be rebased on master to get the CI fix from #212

Definitely needs to be rebased:

==> Pouring [email protected]
454
Error: The `brew link` step did not complete successfully
455
The formula built, but is not symlinked into /usr/local
456
Could not symlink bin/2to3
457
Target /usr/local/bin/2to3
458
already exists. You may want to remove it:
459
  rm '/usr/local/bin/2to3'

@AkihiroSuda
go.mod: pkg/sftp v1.13.3
58fc9a7 
v1.13.0 had a regression, but fixed in v1.13.3

pkg/sftp issue 466

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Member Author

Thanks, rebased

@AkihiroSuda AkihiroSuda merged commit 30cb59c into lima-vm:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

Assignees
No one assigned
Labels
impact/changelog
Projects
None yet
Milestone
v0.6.4
Development

Successfully merging this pull request may close these issues.

Containers can't write to mounted directories
2 participants
@AkihiroSuda @jandubois