go.mod: downgrade pkg/sftp to v1.12.0 (fix nerdctl run -v hang up)
#203
+27
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2021
AkihiroSuda
force-pushed
the
sftp-1.12
branch
from
f322110 to
5b90331
Compare
ref: lima-vm/sshocker PR 14 , pkg/sftp issue 466 Fix issue 187, containerd/nerdctl issue 338 The issue 187 was regression in Lima v0.6.1 (commit fccd9e0) Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
sftp-1.12
branch
from
5b90331 to
1c849a3
Compare
|
I'll release v0.6.3 right after merging this |
|
I'm testing using $ ls -ld /tmp/lima
drwxr-xr-x 3 jan wheel 96 4 Sep 14:42 /tmp/lima
$ lima ls -ld /tmp/lima
drwxr-xr-x 1 root root 96 Sep 4 21:42 /tmp/limaI can create files manually inside the instance with jan@lima-default:/tmp/lima$ mkdir foo
jan@lima-default:/tmp/lima$ touch bar
jan@lima-default:/tmp/lima$ ls -l
total 8
-rw-r--r-- 1 root root 0 Sep 4 21:51 bar
drwxr-xr-x 1 root root 64 Sep 4 21:51 foo
drwxr-xr-x 1 root root 288 Sep 4 21:49 xxxBut when I try to write to the directory from jan@lima-default:/tmp/lima$ nerdctl run -v /tmp/lima:/mnt screen-static-coreos:latest cp -v /home/core/screen-4.8.0/screen /mnt
cp: cannot stat '/mnt/screen': Permission denied |
|
Is that new in this PR? |
No, looks like it has been like this before. But it still means that you can't write to mounted volumes from the container. It is progress though because the container runs at all; before I wouldn't even get the permission error; it would just hang on startup. |
|
Could you open a separate issue after merging this |
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: lima-vm/sshocker#14 , pkg/sftp#466
Fix #187 (
Freezing when trying to map a volume)Fix containerd/nerdctl#338 (
nerdctl run with -v option got stuck without any explicit errors)The issue #187 was regression in Lima v0.6.1 (commit fccd9e0)