SSH: Set UserKnownHostsFile to /dev/null #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are dealing with temporary SSH host keys, we should not pollute the users's known hosts file with ephermeral data. Additionally, this avoids issues where the user has an invalid known hosts file, as in rancher-sandbox/rancher-desktop#504. Signed-off-by: Mark Yen <[email protected]>
AkihiroSuda
reviewed
Aug 20, 2021
| @@ -155,6 +155,7 @@ func CommonArgs(useDotSSH bool) ([]string, error) { | |||
|
|
|||
| args = append(args, | |||
| "-o", "StrictHostKeyChecking=no", | |||
| "-o", "UserKnownHostsFile=/dev/null", | |||
There was a problem hiding this comment.
Do we now want to remove RemoveKnownHostEntries() in L101?
There was a problem hiding this comment.
Do we now want to remove RemoveKnownHostEntries() in L101?
Yes, that function should not be needed anymore if we don't use a known hosts file.
@mook-as can you update the PR to include removal of RemoveKnownHostEntries() (and the call location, of course)?
There was a problem hiding this comment.
Thanks for catching that! Fixed in 08d4bc3
We no longer attempt to touch the known_hosts file. Signed-off-by: Mark Yen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are dealing with temporary SSH host keys, we should not pollute the users's known hosts file with ephemeral data. Additionally, this avoids issues where the user has an invalid known hosts file, as in rancher-sandbox/rancher-desktop#504.