Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host.lima.internal to /etc/hosts #142

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Add host.lima.internal to /etc/hosts #142

merged 1 commit into from
Aug 5, 2021

Conversation

jandubois
Copy link
Member

No description provided.

@jandubois jandubois force-pushed the host-lima-internal branch 2 times, most recently from 50727a5 to 62ba279 Compare August 4, 2021 18:28
@AkihiroSuda AkihiroSuda added this to the v0.6.0 milestone Aug 5, 2021
@jandubois jandubois force-pushed the host-lima-internal branch from 62ba279 to 5cecbf8 Compare August 5, 2021 05:34
AkihiroSuda
AkihiroSuda reviewed Aug 5, 2021
View reviewed changes
docs/internal.md Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda reviewed Aug 5, 2021
View reviewed changes
docs/network.md Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda requested changes Aug 5, 2021
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@jandubois jandubois force-pushed the host-lima-internal branch from 5cecbf8 to 2bf4fe5 Compare August 5, 2021 05:37
AkihiroSuda
AkihiroSuda approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

After merging this, I'll move the repo to lima-vm and release v0.6.0

@AkihiroSuda AkihiroSuda merged commit 5619725 into lima-vm:master Aug 5, 2021
@jandubois jandubois deleted the host-lima-internal branch August 5, 2021 06:32
@AkihiroSuda AkihiroSuda added the enhancement New feature or request label Aug 5, 2021
@jcw-
Copy link

jcw- commented Sep 12, 2021

@jandubois @AkihiroSuda fyi, I struggled a bit trying to use this from an nginx container, as I thought I would be able to use host.lima.internal in the configuration (under Docker I had been using host.docker.internal) - but it's actually only available to the lima VM itself and not available to containers it seems like? I was able to get it to work by using the actual IP of the host loopback directly though...

Screenshot below shows how it's not a meaningful host name in the container:
image

@AkihiroSuda
Copy link
Member

Opened containerd/nerdctl#355 for tracking the issue above

@deviantintegral deviantintegral mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jandubois @jcw- @AkihiroSuda