Refactor: reduce nesting and return error

Signed-off-by: Anders F Björklund <[email protected]>

pkg/cidata/cidata.go

@@ -310,7 +310,10 @@ func GenerateISO9660(instDir, name string, y *limayaml.LimaYAML, udpDNSLocalPort
 		args.CACerts.Trusted = append(args.CACerts.Trusted, cert)
 	}
 
-	args.BootCmds = getBootCmds(y.Provision)
+	args.BootCmds, err = getBootCmds(y.Provision)
+	if err != nil {
+		return err
+	}
 
 	for _, f := range y.Provision {
 		if f.Mode == limayaml.ProvisionModeDependency && *f.SkipDefaultDependencyResolution {
@@ -405,21 +408,22 @@ func getCert(content string) Cert {
 	return Cert{Lines: lines}
 }
 
-func getBootCmds(p []limayaml.Provision) []BootCmds {
+func getBootCmds(p []limayaml.Provision) ([]BootCmds, error) {
 	var bootCmds []BootCmds
 	for _, f := range p {
-		if f.Mode == limayaml.ProvisionModeBoot {
-			lines := []string{}
-			for _, line := range strings.Split(f.Script, "\n") {
-				if line == "" {
-					continue
-				}
-				lines = append(lines, strings.TrimSpace(line))
+		if f.Mode != limayaml.ProvisionModeBoot {
+			continue
+		}
+		lines := []string{}
+		for _, line := range strings.Split(f.Script, "\n") {
+			if line == "" {
+				continue
 			}
-			bootCmds = append(bootCmds, BootCmds{Lines: lines})
+			lines = append(lines, strings.TrimSpace(line))
 		}
+		bootCmds = append(bootCmds, BootCmds{Lines: lines})
 	}
-	return bootCmds
+	return bootCmds, nil
 }
 
 func diskDeviceNameFromOrder(order int) string {