Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented OneWeekView and TwoWeeksView #106

Merged
merged 6 commits into from
Oct 11, 2021
Merged

Implemented OneWeekView and TwoWeeksView #106

merged 6 commits into from
Oct 11, 2021

Conversation

tborozan
Copy link
Member

@tborozan tborozan commented Aug 6, 2021

New concept LayoutUnit:
Represents a week, two weeks or month depending on CalendarLayout property

Added:

  • CalendarPlugin
    • CalendarLayout - indicates selected layout
    • WeekViewUnit - represents LayoutUnit naming scheme (month name/week number)
    • ViewLayoutEngine - generated layout based on CalendarLayout
  • SampleApp
    • OneWeekView
    • TwoWeeksView

Renamed:

  • MonthYear -> ShownDate
  • ShowMonthPicker -> ShowLayoutUnitPicker
  • MonthText -> LayoutUnitText
  • PrevMonthCommand -> PrevLayoutUnitCommand
  • NextMonthCommand -> PrevLayoutUnitCommand

@tborozan tborozan requested a review from antonioseric August 6, 2021 13:56
@tborozan tborozan linked an issue Aug 6, 2021 that may be closed by this pull request
@tborozan tborozan requested a review from bbazina August 18, 2021 11:46
@antonioseric antonioseric requested review from bmatea and dujesa and removed request for bbazina September 7, 2021 13:54
Copy link
Contributor

@m-luketin m-luketin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When entering the single and two week view calendar sample, there is a snappy change a few seconds after the page seems fully loaded, and then another one after a second or so. It's confusing for the user opening the sample, especially if they attempt to tap anything.

Its unclear why some events have a margin, while others dont.

Copy link
Contributor

@m-luketin m-luketin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems in order. I just want to mention that, until now, days that don't belong to the selected month had the disabled color, which is not the case on the 1 and 2 week calendars. If this is intended then ok. (e.g. if we are on september, and the 1st and 2nd of october are visible, they would have the disabled color for the date number)

Copy link
Contributor

@antonioseric antonioseric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is wrong with event list when there is 5 or less events
Screenshot_1633279628

@antonioseric antonioseric merged commit 2fc44d9 into master Oct 11, 2021
@antonioseric antonioseric deleted the week-view branch October 11, 2021 09:18
kvpt added a commit to kvpt/Xamarin.Plugin.Calendar that referenced this pull request Nov 16, 2021
@inimirpaz
Copy link

  • PrevMonthCommand -> PrevLayoutUnitCommand

  • NextMonthCommand -> PrevLayoutUnitCommand

The second one is actually NextLayoutUnitCommand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I create another branch,Added Week View
5 participants