-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented OneWeekView and TwoWeeksView #106
Conversation
src/Calendar.Plugin.Sample/SampleApp/ViewModels/AdvancedPageViewModel.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When entering the single and two week view calendar sample, there is a snappy change a few seconds after the page seems fully loaded, and then another one after a second or so. It's confusing for the user opening the sample, especially if they attempt to tap anything.
Its unclear why some events have a margin, while others dont.
src/Calendar.Plugin/Shared/Controls/ViewLayoutEngines/MonthViewEngine.cs
Outdated
Show resolved
Hide resolved
src/Calendar.Plugin/Shared/Controls/ViewLayoutEngines/MonthViewEngine.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems in order. I just want to mention that, until now, days that don't belong to the selected month had the disabled color, which is not the case on the 1 and 2 week calendars. If this is intended then ok. (e.g. if we are on september, and the 1st and 2nd of october are visible, they would have the disabled color for the date number)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
48a59fe
to
2a97d85
Compare
This correct the regression introduced by PR lilcodelab#106
The second one is actually |
New concept LayoutUnit:
Represents a week, two weeks or month depending on
CalendarLayout
propertyAdded:
CalendarLayout
- indicates selected layoutWeekViewUnit
- represents LayoutUnit naming scheme (month name/week number)ViewLayoutEngine
- generated layout based onCalendarLayout
OneWeekView
TwoWeeksView
Renamed:
MonthYear
->ShownDate
ShowMonthPicker
->ShowLayoutUnitPicker
MonthText
->LayoutUnitText
PrevMonthCommand
->PrevLayoutUnitCommand
NextMonthCommand
->PrevLayoutUnitCommand