Decide the default matrix binding of the result by majority voting #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, the default matrix binding (i.e.
unidata._cur_matrix
) is decided by taking the first key from theunidata.matrices
map. This way has 2 drawbacks:a
, it's still possible that the binding of the resulting data object isb
.Solution
This PR decides it in a more intuitive way: choose the matrix key used in the majority of the source data objects as the new default binding.