Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jepsen-long-fork model #43

Closed
ligurio opened this issue May 2, 2022 · 0 comments · Fixed by #78
Closed

Fix jepsen-long-fork model #43

ligurio opened this issue May 2, 2022 · 0 comments · Fixed by #78

Comments

@ligurio
Copy link
Owner

ligurio commented May 2, 2022 •
edited
Loading

jepsen-long-fork model is mentioned in documentation and usage, but actually is broken.

elle-cli/src/elle_cli/cli.clj

Lines 174 to 178 in d23bf96

"jepsen" (case model-name
"jepsen-bank" (jepsen-model/check-safe (checker-fn {:negative-balances? true}) nil history)
"jepsen-set-full" (jepsen-model/check-safe (checker-fn) nil history)
"jepsen-counter" (jepsen-model/check-safe (checker-fn) nil history)
))))

@ligurio ligurio changed the title Fix long-fork model Fix jepsen-long-fork model May 2, 2022
ligurio added a commit that referenced this issue Nov 5, 2024
@ligurio
Fix a long-fork checker
d3b013a 
```
$ java -jar ~/sources/elle-cli/target/elle-cli-0.1.7-standalone.jar --verbose --model long-fork histories/jepsen/long-fork.edn
{"reads-count":2,
 "early-read-count":0,
 "late-read-count":0,
 "valid?":false,
 "forks":
 [[{"index":3,
    "time":-1,
    "type":"ok",
    "process":null,
    "f":"read",
    "value":[["r", 2, 1], ["r", 0, 1], ["r", 1, null]]},
   {"index":1,
    "time":-1,
    "type":"ok",
    "process":null,
    "f":"read",
    "value":[["r", 0, 1], ["r", 1, 1], ["r", 2, null]]}]]}
```

Fixes #43
@ligurio ligurio mentioned this issue Nov 5, 2024
Merged
ligurio added a commit that referenced this issue Nov 5, 2024
@ligurio
Fix a long-fork checker
ff38f2e 
```
$ java -jar ~/sources/elle-cli/target/elle-cli-0.1.7-standalone.jar --verbose --model long-fork histories/jepsen/long-fork.edn
{"reads-count":2,
 "early-read-count":0,
 "late-read-count":0,
 "valid?":false,
 "forks":
 [[{"index":3,
    "time":-1,
    "type":"ok",
    "process":null,
    "f":"read",
    "value":[["r", 2, 1], ["r", 0, 1], ["r", 1, null]]},
   {"index":1,
    "time":-1,
    "type":"ok",
    "process":null,
    "f":"read",
    "value":[["r", 0, 1], ["r", 1, 1], ["r", 2, null]]}]]}
```

Fixes #43
ligurio added a commit that referenced this issue Nov 5, 2024
@ligurio
Fix a long-fork checker
357a768 
```
$ java -jar ~/sources/elle-cli/target/elle-cli-0.1.7-standalone.jar --verbose --model long-fork histories/jepsen/long-fork.edn
{"reads-count":2,
 "early-read-count":0,
 "late-read-count":0,
 "valid?":false,
 "forks":
 [[{"index":3,
    "time":-1,
    "type":"ok",
    "process":null,
    "f":"read",
    "value":[["r", 2, 1], ["r", 0, 1], ["r", 1, null]]},
   {"index":1,
    "time":-1,
    "type":"ok",
    "process":null,
    "f":"read",
    "value":[["r", 0, 1], ["r", 1, 1], ["r", 2, null]]}]]}
```

Fixes #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix long fork checker ligurio/elle-cli
1 participant
@ligurio