Upgrade half library to 2.2 #755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling with `cmake . -DUSE_BACKEND=CUDA -DCMAKE_CXX_FLAGS='-march=native'` on a CPU with F16C intrinsics yielded the same errors as issue lightvector#387: > error: ‘_mm_set_ss’ was not declared in this scope The cause is that _mm_set_ss is defined in a header imported from immintrin.h, which is included in cpp/external/half-2.1.0/include/half.hpp:272. However, it is only included if the preprocessor macro HALF_ENABLE_F16C_INTRINSICS is set, but in turn, that is only set in cpp/external/half-2.1.0/include/half.hpp:283, a few lines too late. This issue seems fixed in half-2.2.0, thus we upgrade to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling with
cmake . -DUSE_BACKEND=CUDA -DCMAKE_CXX_FLAGS='-march=native'on a CPU with F16C intrinsics yielded the same errors as issue #387:The cause is that _mm_set_ss is defined in a header imported from immintrin.h, which is included in
cpp/external/half-2.1.0/include/half.hpp:272.
However, it is only included if the preprocessor macro HALF_ENABLE_F16C_INTRINSICS is set, but in turn, that is only set in cpp/external/half-2.1.0/include/half.hpp:283, a few lines too late.
This issue seems fixed in half-2.2.0, thus we upgrade to it.
I compiled and ran the new code in GTP against Sabaki and played a game without issue.