Exit with error code 1 when no episode was downloaded #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lightpohl
requested changes
Jul 28, 2021
There was a problem hiding this comment.
Hey! Thanks for the PR! 👏
This seems like it could be useful in a few situations so I would like to get a variation of this into the next release.
I have a few requested changes below — let me know if you'd like to tackle them! If not, I can make the changes when I have some time later. 👍
lightpohl
approved these changes
Jul 30, 2021
|
Awesome! Thanks again! Merged it but going to wait for the other PR and a couple small personal todo items before publishing. 🚀 |
lightpohl
pushed a commit
that referenced
this pull request
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just closed #26 and this is a better implementation...
As I mentioned in #17 I use a systemd timer to start
podcast-dl.But I realized that my favorite podcast is uploaded often on Thursday mornings, but quite some times on Thursday evenings or even on Friday or Saturday. Either I set my timer on Sunday than I can be sure that the podcast is uploaded already. Or I just retry to download it every three hours until it succeeds by using following:
However systemd's
Restart=on-failurejust works with exit codes other than zero. So this pull request is one way to achieve this :)