fix: prevent podcast images from downloading if already archived

closes #39
lightpohl · Apr 11, 2022 · c1a7440 · c1a7440
1 parent e7c189b
commit c1a7440
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 24 deletions.
diff --git a/bin/async.js b/bin/async.js
@@ -22,6 +22,7 @@ import {
   writeItemMeta,
   writeToArchive,
   getUrlEmbed,
+  getIsInArchive,
 } from "./util.js";
 
 const pipeline = promisify(stream.pipeline);
@@ -44,6 +45,11 @@ const download = async ({
     return;
   }
 
+  if (key && archive && getIsInArchive({ key, archive })) {
+    logMessage("Download exists in archive. Skipping...");
+    return;
+  }
+
   let embeddedUrl = null;
   if (filterUrlTracking) {
     logMessage("Attempting to find embedded URL...");

diff --git a/bin/util.js b/bin/util.js
@@ -215,22 +215,20 @@ const getItemsToDownload = ({
             }),
           });
 
-          if (!savedArchive.includes(episodeImageArchiveKey)) {
-            const episodeImageName = getFilename({
-              item,
-              feed,
-              url: episodeAudioUrl,
-              ext: episodeImageFileExt,
-              template: episodeTemplate,
-            });
-
-            const outputImagePath = path.resolve(basePath, episodeImageName);
-            item._extra_downloads.push({
-              url: episodeImageUrl,
-              outputPath: outputImagePath,
-              key: episodeImageArchiveKey,
-            });
-          }
+          const episodeImageName = getFilename({
+            item,
+            feed,
+            url: episodeAudioUrl,
+            ext: episodeImageFileExt,
+            template: episodeTemplate,
+          });
+
+          const outputImagePath = path.resolve(basePath, episodeImageName);
+          item._extra_downloads.push({
+            url: episodeImageUrl,
+            outputPath: outputImagePath,
+            key: episodeImageArchiveKey,
+          });
         }
       }
 
@@ -295,7 +293,7 @@ const logItemsList = ({
 
 const writeFeedMeta = ({ outputPath, feed, key, archive, override }) => {
   if (key && archive && getIsInArchive({ key, archive })) {
-    logMessage("Feed metadata exists in archive. Skipping write...");
+    logMessage("Feed metadata exists in archive. Skipping...");
     return;
   }
 
@@ -312,7 +310,7 @@ const writeFeedMeta = ({ outputPath, feed, key, archive, override }) => {
     if (override || !fs.existsSync(outputPath)) {
       fs.writeFileSync(outputPath, JSON.stringify(output, null, 4));
     } else {
-      logMessage("Feed metadata exists locally. Skipping write...");
+      logMessage("Feed metadata exists locally. Skipping...");
     }
 
     if (key && archive && !getIsInArchive({ key, archive })) {
@@ -338,9 +336,7 @@ const writeItemMeta = ({
   override,
 }) => {
   if (key && archive && getIsInArchive({ key, archive })) {
-    logMessage(
-      `${marker} | Episode metadata exists in archive. Skipping write...`
-    );
+    logMessage(`${marker} | Episode metadata exists in archive. Skipping...`);
     return;
   }
 
@@ -355,9 +351,7 @@ const writeItemMeta = ({
     if (override || !fs.existsSync(outputPath)) {
       fs.writeFileSync(outputPath, JSON.stringify(output, null, 4));
     } else {
-      logMessage(
-        `${marker} | Episode metadata exists locally. Skipping write...`
-      );
+      logMessage(`${marker} | Episode metadata exists locally. Skipping...`);
     }
 
     if (key && archive && !getIsInArchive({ key, archive })) {