fix: add download cleanup on error:

lightpohl · May 9, 2020 · 978db00 · 978db00
1 parent a8c6583
commit 978db00
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 15 deletions.
diff --git a/bin/util.js b/bin/util.js
@@ -225,20 +225,28 @@ let download = async ({ url, outputPath, key, archive }) => {
     return;
   }
 
-  await pipeline(
-    got
-      .stream(url)
-      .on("downloadProgress", (progress) => {
-        printProgress(progress);
-      })
-      .on("end", () => {
-        endPrintProgress();
-      }),
-    fs.createWriteStream(outputPath)
-  );
-
-  if (key && archive && !getIsInArchive({ key, archive })) {
-    writeToArchive({ key, archive });
+  try {
+    await pipeline(
+      got
+        .stream(url)
+        .on("downloadProgress", (progress) => {
+          printProgress(progress);
+        })
+        .on("end", () => {
+          endPrintProgress();
+
+          if (key && archive && !getIsInArchive({ key, archive })) {
+            writeToArchive({ key, archive });
+          }
+        }),
+      fs.createWriteStream(outputPath)
+    );
+  } catch (error) {
+    if (fs.existsSync(outputPath)) {
+      fs.unlinkSync(outputPath);
+    }
+
+    throw error;
   }
 };
 

diff --git a/bin/validate.js b/bin/validate.js
@@ -2,7 +2,7 @@ const logError = (msg, error) => {
   console.error(msg);
 
   if (error) {
-    console.error(error);
+    console.error(error.message);
   }
 };