Fetch polyfill #312
Merged
Fetch polyfill #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
fetch-polyfill
branch
from
45fe484 to
c35328b
Compare
krichprollsch
force-pushed
the
fetch-polyfill
branch
2 times, most recently
from
8dc07f5 to
6757fba
Compare
krichprollsch
force-pushed
the
fetch-polyfill
branch
from
6757fba to
adfffd2
Compare
|
follow-up: #319 |
src/polyfill/fetch.zig
Outdated
| // wget $(npm view whatwg-fetch dist.tarball) | ||
| // | ||
| // The source is the content of `package/dist/fetch.umd.js` file. | ||
| pub const source = |
There was a problem hiding this comment.
What about commit the js file directly and use the directive @embedFile?
There was a problem hiding this comment.
It will be easier to read and modify if needed.
There was a problem hiding this comment.
I didn't know @embedFile, ty 🙏
It's much better to keep a separated pure js file.
tests/html/await-fetch.html
Outdated
| @@ -0,0 +1,10 @@ | |||
| <script> | |||
There was a problem hiding this comment.
Where is this test is played?
There was a problem hiding this comment.
I used the file for manual tests. Removed now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.