Deprecate dust-threshold config value #9182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saubyk
changed the title
ziggie1984
force-pushed
the
fix-feebuffer
branch
2 times, most recently
from
f8ce024
to
c0f0f04
Compare
ziggie1984
changed the title
ziggie1984
changed the title
ziggie1984
force-pushed
the
fix-feebuffer
branch
from
c0f0f04
to
e31c4d8
Compare
ziggie1984
force-pushed
the
fix-feebuffer
branch
2 times, most recently
from
7514a69
to
4c395e8
Compare
ziggie1984
force-pushed
the
fix-feebuffer
branch
from
4c395e8
to
7ff237e
Compare
saubyk
reviewed
Oct 22, 2024
ziggie1984
force-pushed
the
fix-feebuffer
branch
from
7ff237e
to
7454f12
Compare
ziggie1984
force-pushed
the
fix-feebuffer
branch
from
7454f12
to
17e9bd0
Compare
|
@yyforyongyu: review reminder |
yyforyongyu
reviewed
Nov 6, 2024
config.go
Outdated
| // Don't allow both the old dust-threshold and the new | ||
| // channel-max-fee-exposure to be set. | ||
| defaultExposure := uint64(htlcswitch.DefaultMaxFeeExposure.ToSatoshis()) | ||
| if cfg.DustThreshold != 0 && cfg.MaxFeeExposure != defaultExposure { |
There was a problem hiding this comment.
Q: why are we checking cfg.MaxFeeExposure != defaultExposur but not cfg.MaxFeeExposure != 0?
There was a problem hiding this comment.
I see it's set in the default, hmmm, then we'd have this issue, what if i run,
./lnd-debug --dust-threshold=100 --channel-max-fee-exposure=500000There was a problem hiding this comment.
ok changed thanks for pointing this out
ziggie1984
force-pushed
the
fix-feebuffer
branch
from
17e9bd0
to
7252248
Compare
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Replace ambigious config value "dust-treshold" with a more clear "channel-max-fee-exposure" exposure value. The old value is deprecated and will be removed in the near future.
ziggie1984
force-pushed
the
fix-feebuffer
branch
from
7252248
to
69b5e3d
Compare
Because we need to remain backwards compatible with the old `dust-threshold` value we set the default value for `channel-max-fee-exposure` later in the program flow. Given the restrictions of the sample config check we need to exclude this value from the check.
ziggie1984
force-pushed
the
fix-feebuffer
branch
from
69b5e3d
to
aebf03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a more clear config value and deprecated the old
dust-thresholdvalue. The new setting is calledchannel-max-fee-exposure. Nothing has changed code wise, the new value behaves as the old one but is way clearer and removes the ambiguity