[5/5]sweep: introduce budget-based deadline aware fee bumper #8424
Commits on Apr 2, 2024
-
sweep: expand
InputSetwith more interface methodsThis commit adds more interface methods to `InputSet` to prepare the addition of budget-based aggregator.
-
sweep: change
markInputsPublishFailedto take outpointsThis way it's easier to pass values to this method in various callsites.
-
sweep: refactor
markInputsPendingPublishto takeInputSetThis commit changes `markInputsPendingPublish` to take `InputSet` only. This is needed for the following commits as we won't be able to know the tx being created beforehand, yet we still want to make sure these inputs won't be grouped to another input set as it complicates our RBF process.
-
sweep: introduce
BudgetInputSetto manage budget-based inputsThis commit adds `BudgetInputSet` which implements `InputSet`. It handles the pending inputs based on the supplied budgets and will be used in the following commit.
-
sweep: introduce
BudgetAggregatorto cluster inputs by deadlinesThis commit adds `BudgetAggregator` as a new implementation of `UtxoAggregator`. This aggregator will group inputs by their deadline heights and create input sets that can be used directly by the fee bumper for fee calculations.
-
sweep: introduce
Bumperinterface to handle RBFThis commit adds a new interface, `Bumper`, to handle RBF for a given input set. It's responsible for creating the sweeping tx using the input set, and monitors its confirmation status to decide whether a RBF should be attempted or not. We leave implementation details to future commits, and focus on mounting this `Bumper` interface to our sweeper in this commit.
-
-
sweep: remove RBF related tests
As there will be dedicated new tests for them.
-
sweep: remove
FeeRate()fromInputSetinterfaceAs shown in the following commit, fee rate calculation will now be handled by the fee bumper, hence there's no need to expose this on `InputSet` interface.
-
sweep: add
FeeFunctioninterface and a linear implementationThis commit adds a new interface, `FeeFunction`, to deal with calculating fee rates. In addition, a simple linear function is implemented, hence `LinearFeeFunction`, which will be used to calculate fee rates when bumping fees. Check lightningnetwork#4215 for other type of fee functions that can be implemented.
-
-
lnwallet+sweep: calculate max allowed feerate on
BumpResultThis commit adds the method `MaxFeeRateAllowed` to calculate the max fee rate. The caller may specify a large MaxFeeRate value, which cannot be cover by the budget. In that case, we default to use the max feerate calculated using `budget/weight`.
-
lnwallet+sweep: introduce
TxPublisherto handle fee bumpThis commit adds `TxPublisher` which implements `Bumper` interface. This is part one of the implementation that focuses on implementing the `Broadcast` method which guarantees a tx can be published with RBF-compliant. It does so by leveraging the `testmempoolaccept` API, keep increasing the fee rate until an RBF-compliant tx is made and broadcasts it. This tx will then be monitored by the `TxPublisher` and in the following commit, the monitoring process will be added.
-
sweep: add monitor loop to
TxPublisherThis commit finishes the implementation of `TxPublisher` by adding the monitor process. Whenever a new block arrives, the publisher will check all its monitored records and attempt fee bumping them if necessary.
-
-
sweep: increase delta fee rate precision in fee function
This commit adds a private type `mSatPerKWeight` that expresses a given fee rate in millisatoshi per kw. This is needed to increase the precision of the fee function. When sweeping anchor inputs, if using a deadline delta of over 1000, it's likely the delta will be 0 sat/kw due to precision.
-
-
-
sweep: make sure non-fee related errors are notified
So these inputs can be retried by the sweeper.
