buildroute use lnd default #8387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggie1984
force-pushed
the
buildroute-use-lnd-default
branch
from
bd457f6 to
12ee38a
Compare
guggero
reviewed
Jan 16, 2024
This commit uses the default timelock delta (cltv delta) when no value is provided for the buildroute rpc cmd. Moreover it enhances the docs.
ziggie1984
force-pushed
the
buildroute-use-lnd-default
branch
from
12ee38a to
1880343
Compare
Now the default of the lnd backend is used instead of providing the default value via the caller of the buildroute rpc cmd.
ziggie1984
force-pushed
the
buildroute-use-lnd-default
branch
from
1880343 to
2db5752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8380.
Now the lncli does not provide a default value but we check on the lnd side and if its not provided we use the lnd default.
Moreover improves the docs.