Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainntnfs: increase timeout in unit tests #8360

Closed

Conversation

yyforyongyu
Copy link
Member

Fix the unit test flake we've seen recently,

--- FAIL: TestHistoricalConfDetailsTxIndex (0.00s)
    --- FAIL: TestHistoricalConfDetailsTxIndex/rpc_polling_enabled (10.28s)
        bitcoind_test.go:126: unable to establish connection to bitcoind: method did not return within the timeout

Also remove the `t.Helper()` so it's easier to trace down the errors.
@guggero
Copy link
Collaborator

guggero commented Jan 9, 2024

I'm not sure if it's actually a question of how long we wait. A lot of tests fail on my local machine because there are port collisions. So I think this will likely be fixed with #8273 (which I should look into to fix the new failures that popped up now).

@yyforyongyu
Copy link
Member Author

I'm not sure if it's actually a question of how long we wait. A lot of tests fail on my local machine because there are port collisions. So I think this will likely be fixed with #8273 (which I should look into to fix the new failures that popped up now).

yeah i also saw port collision sometimes in lnd, but only during the shutdown process where the rpc port was not cleaned. Have not yet seen such a case in unit test tho.

@yyforyongyu yyforyongyu closed this May 2, 2024
@yyforyongyu yyforyongyu deleted the fix-bitcoind-flake branch May 2, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants