multi: rename kvdb Read* types to R* #4252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfromknecht
requested review from
halseth,
joostjager,
Roasbeef and
wpaulino
as code owners
wpaulino
approved these changes
May 7, 2020
cfromknecht
force-pushed
the
rename-kvdb-read
branch
from
e557213 to
04abccf
Compare
|
rebased to fix conflicts with #4280 |
|
Needs a rebase now that the larger PR has gone in. |
|
One last rebase... |
cfromknecht
force-pushed
the
rename-kvdb-read
branch
from
04abccf to
d0f3f61
Compare
cfromknecht
added a commit
to cfromknecht/lnd
that referenced
this pull request
May 28, 2020
We recently renamed kvdb.ReadBucket to kvdb.RBucket in lightningnetwork#4252, but this was not detected in lightningnetwork#4285 since this new code didn't produce a conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #3833