Skip to content

Commit

Permalink
lnrpc: set JS_STRING option for chan_id
Browse files Browse the repository at this point in the history
This sets the `jstype` option to `JS_STRING` for all `chan_id` fields
in the proto rpc definition. `chan_id` is a 64 bit integer, which is
not natively supported by javascript's floating-point `number` with
only 52 bit precision. Nevertheless, by default protobuf will use the
`number` type for 64 bit integer fields in javascript, which can cause
loss of precision problems with `chan_id`. Explicitly setting the type
for javascript as a string will prevent these issues, and should not
interfere with its use as an identifier.
  • Loading branch information
sangaman committed Oct 14, 2019
1 parent faacd8d commit f437b35
Show file tree
Hide file tree
Showing 4 changed files with 667 additions and 665 deletions.
Loading

0 comments on commit f437b35

Please sign in to comment.