Update deprecated flag and homepage field #358
Conversation
| @@ -2,7 +2,7 @@ | |||
| "name": "lightning-app", | |||
| "version": "0.1.0", | |||
| "description": "Lightning Wallet Application", | |||
| "homepage": "https://lightning.engineering", | |||
| "homepage": "./", | |||
There was a problem hiding this comment.
The npm docs say this attribute is for the project homepage? https://docs.npmjs.com/files/package.json#homepage
There was a problem hiding this comment.
https://github.com/facebook/create-react-app/blob/ca7d227ae0354e04941ba0e4f76c0bcbf3050dfa/config/webpack.config.prod.js#L20-L23 create-react-app uses package.json's homepage field when it creates the webpack config as webpack's publicPath, which is what the static files are served from. Got this fix from here: facebook/create-react-app#165 lmk if it isn't acceptable
| @@ -16,7 +16,7 @@ | |||
| "test:react": "react-scripts test --env=jsdom", | |||
| "eject": "react-scripts eject", | |||
| "electron-dev": "concurrently \"BROWSER=none npm start\" \"wait-on http://localhost:3000 && electron --enable-sandbox .\"", | |||
| "electron-pack": "build --em.main=build/electron.js", | |||
| "electron-pack": "build --c.extraMetadata.main=build/electron.js", | |||
There was a problem hiding this comment.
I think both changes are necessary
Do you mean during development or for the build? During development you just have to make sure you have lnd/btcd in your |
I mean for the build of the packaged app, but in both cases i needed to do this. i'm confused why it would work otherwise due to the structure of |
|
@valentinewallace Ok. Tested this. Looks good 👍 |
I copied the changes over from my Ubuntu VM so hopefully they work.
Additionally, I had to
cpmy lnd and btcd binaries into theassets/build/linuxfolder for the package to build correctly (symlinks didn't work). Not sure if this should be put into the README or what?