Avoid an unnecessary allocation in TaggedHash
#2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A well-formed tag is always a constant, so allocating to store it is unnecessary when we can just make the tag a `&'static str`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
==========================================
- Coverage 88.85% 88.81% -0.04%
==========================================
Files 113 113
Lines 89170 89170
Branches 89170 89170
==========================================
- Hits 79228 79197 -31
- Misses 7699 7725 +26
- Partials 2243 2248 +5
☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Nov 7, 2023
jkczyz
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A well-formed tag is always a constant, so allocating to store it is unnecessary when we can just make the tag a
&'static str.