Skip to content

Commit

Permalink
f sp
Browse files Browse the repository at this point in the history
  • Loading branch information
TheBlueMatt committed May 10, 2023
1 parent ecc3ec5 commit 0902fe4
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions lightning/src/ln/channelmanager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -538,12 +538,11 @@ impl_writeable_tlv_based_enum_upgradable!(MonitorUpdateCompletionAction,
(0, PaymentClaimed) => { (0, payment_hash, required) },
(2, EmitEventAndFreeOtherChannel) => {
(0, event, upgradable_required),
// LDK prior to 0.0.115 did not have this field as the monitor update application order was
// required by clients. If we downgrade to something prior to 0.0.115 this may result in
// LDK prior to 0.0.116 did not have this field as the monitor update application order was
// required by clients. If we downgrade to something prior to 0.0.116 this may result in
// monitor updates which aren't properly blocked or resumed, however that's fine - we don't
// support async monitor updates even in LDK 0.0.115 and once we do we'll require no
// downgrades to prior versions. Thus, while this would break on downgrade, we don't
// support it even without downgrade, so if it breaks its not on us ¯\_(ツ)_/¯.
// support async monitor updates even in LDK 0.0.116 and once we do we'll require no
// downgrades to prior versions.
(1, downstream_counterparty_and_funding_outpoint, option),
},
);
Expand Down

0 comments on commit 0902fe4

Please sign in to comment.