Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to LdkServer. #24

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Nov 22, 2024

No description provided.

@G8XSU G8XSU requested a review from arik-so November 22, 2024 23:34
@G8XSU G8XSU force-pushed the ldk-server-rename branch from 050a3fa to 144d732 Compare November 23, 2024 00:43
@G8XSU
Copy link
Contributor Author

G8XSU commented Nov 23, 2024

Rebased on main

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the package names for cli, client, and protos will also need to be renamed before we're able to publish them. What is the current thinking on the naming scheme here?

@G8XSU
Copy link
Contributor Author

G8XSU commented Nov 25, 2024

Seems the package names for cli, client, and protos will also need to be renamed before we're able to publish them. What is the current thinking on the naming scheme here?

Yes, I was thinking of renaming them to ldk-server-* i.e., ldk-server-cli, ldk-server-client, ldk-server-protos/ldk-server-types, ldk-server.
Lmk if you think there are any alternatives in that case.

I am going to merge this one, since i need to base my PRs off of this.

@G8XSU G8XSU merged commit a5178ec into lightningdevkit:main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants